change mock doc url to look more mock-like #33128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Dec 5, 2023
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
erohmensing
force-pushed
the
ella/mock-doc-url
branch
from
77633c3 to
2e0d3fd
Compare
erohmensing
changed the base branch from
ella/fix-base-image-metadata-tests
to
ella/fix-metadata-tests
erohmensing
force-pushed
the
ella/fix-metadata-tests
branch
from
8e3ec2b to
7178a98
Compare
erohmensing
added a commit
that referenced
this pull request
Dec 5, 2023
Now that tests are running again, some tests were failing on master. This fixes those tests. Steps to fix: - docker images need to follow our exists/doesn't exist pattern for stubs - doc url needs to be the stubbed doc url - changed the info to say alloydb because the stubbed doc url is alloydb. This wasn't strictly necessary to get them passing. I'll update the mock to be more general in [another pr](#33128).
erohmensing
force-pushed
the
ella/mock-doc-url
branch
from
2e0d3fd to
e8a3b64
Compare
bnchrch
approved these changes
Dec 6, 2023
rishabh-cldcvr
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Dec 14, 2023
Now that tests are running again, some tests were failing on master. This fixes those tests. Steps to fix: - docker images need to follow our exists/doesn't exist pattern for stubs - doc url needs to be the stubbed doc url - changed the info to say alloydb because the stubbed doc url is alloydb. This wasn't strictly necessary to get them passing. I'll update the mock to be more general in [another pr](airbytehq#33128).
rishabh-cldcvr
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to know that the url is being validated in the test if it doesn't look like a standard URL. With a standard URL, you might think that the data from any connector is valid, which it is not, because the existence check is stubbed.